Real metric names #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with a weight multiplier of 1 so that it doesn't actually have a weight. just to appease TS
to remove mapping
|
@swellander is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
swellander
commented
Jul 27, 2024
swellander
commented
Jul 27, 2024
swellander
commented
Jul 27, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
escottalexander
requested changes
Jul 28, 2024
There was a problem hiding this comment.
This is great. Appreciate you doing this. One issue is that we will still need the mapping. The source for the metric names was a static data set that had the mapping already added to each project but in the future we will pull the data from a different source and it is unlikely that this data will include the mapping data. Feel free to reach out for more clarity.
swellander
force-pushed
the
real-metric-names
branch
from
cffcb1b
to
28c1bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates our metric names and OSO data to be in sync with the current version of OSO's API. Running a yarn seed --reset is needed for this branch to work locally
Additional Information
seed.sample.jsonwith the new metricsmappingobject, that we no longer need because OSO includes anapplication_idfield that is also the project's ID on Agora.